Open
Conversation
- Removed unnecessary files - Added first tests - Added first components - Added dependencies for testing
…not yet created components
- First iteration for base components - Modified Header structure: created StyledSection component to a better arrangement of components
- Added card component - Added HomeVideos component - Added tests for new added components - Added/refactored styles for HomeVideo and Card component - Refactored tests for Card component
…ests refactor to comply just with react-testing-library
- Added roles to elements to improve accesibility - Refactored tests to find elements by role instead of their id
- ✨ Added theming prototype - ✅ Added first specs to test integration with theming
- Changed directory name 'Base' to 'ui', indicating that files contained here will be for general UI integration - Updated tests in Card component
- Refactored code - Moved mocked files to a new folder - Mocked API calls - Created tests for custom hooks
- Added test for YT playback frame - Added component for youtube playback
- Added SmallVideoCard component - Added RelatedVideoList component - Added styles for each new component - Added tests for each new component
- Removed unnecesary code from VideoPlayerContainer - Added tests to assert small captions video change - Improved code format
- Added AppContext to share global context - Moved theme spec to AppContext - Moved useSearch to App.jsx component - Added appReducer for global context: AppContext - Deleted unnecessary files
- Added test for useReducer, googleMockedAPIObject files - Prevented props passing from parent componenst to child componenst using context props - Reformated code on some files
jparciga
reviewed
Mar 18, 2021
jparciga
left a comment
jparciga
left a comment
There was a problem hiding this comment.
Mini-Challenge 4 Feedback
Great job 👏🏻!
Acceptance Criteria
✅ The search term is stored and retrieved from the Global Context correctly. - Not exactly, but the desired functionality was achieved.
✅ The appearance theme is stored on the Global Context and applied correctly to the App UI.
✅ useReducer hook is implemented correctly to manage the Global State.
Bonus Points
✅. Testing coverage is above 70%. (Please include a screenshot of the code coverage report in your PR description).
Comment on lines
+46
to
+54
| it('applies background for light theme', async () => { | ||
| const { firstChild } = (await build()).container; | ||
| expect(firstChild).toHaveStyle(`background: ${lightTheme.color.background}`); | ||
| }); | ||
|
|
||
| it('applies background for dark theme', async () => { | ||
| const { firstChild } = (await build(<LayoutWrapper/>, darkTheme)).container; | ||
| expect(firstChild).toHaveStyle(`background: ${darkTheme.color.background}`); | ||
| }); |
Author
There was a problem hiding this comment.
OMG, I wasn't expecting a review so soon.
I forgot to add a screenshot of the test coverage, I also added an update.
This is the new coverage:
Given that the gapi object is available once the youtube script is loaded, I wasn't being checking that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR do?
Performs tasks for mini challenge 4
Any background context you want to provide?
Big refactors, added lots of new tests. 👀 🧪
Where should the reviewer start?
How should this be manually tested?
Screenshots
OMG! 😃